Respect logger_class setting unless statsd is on #853
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # if statsd is on, automagically switch to the statsd logger | ||
| if 'statsd_host' in self.settings: | ||
| if 'statsd_host' in self.settings and self.settings['statsd_host'].value is not None: |
There was a problem hiding this comment.
Could be written simply as if self.settings.get('statsd_host') is not None
There was a problem hiding this comment.
Just my style. Ignore me. It's fine :-D
🍻
|
Thanks for checking into this. The fix looks good. |
tilgovi
added a commit
that referenced
this pull request
Aug 16, 2014
Respect logger_class setting unless statsd is on
|
I've just ran The online documentation is up-to-date. |
|
Thanks, @berkerpeksag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #848.
If
--statsd-hostis set to some value, it will setlogger_classto the StatsD logger. If the option is not present it respects anylogger_classthat is passed as an option.